Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the tv API #13

Merged
merged 13 commits into from
Oct 1, 2019
Merged

Conversation

foreign-sub
Copy link

@foreign-sub foreign-sub commented Sep 10, 2019

Support for the freebox os tv API
Api calls:
get_finished_tv_records
get_tv_bouquet_channels
get_tv_bouquet
get_tv_channels
get_tv_default_bouquet_channels
get_tv_program
get_tv_program_highlights
get_tv_programs_by_channel
get_tv_programs_by_date
create_tv_record
create_tv_record_generator
edit_tv_record_generator
get_tv_record_generator
get_tv_records_configuration
get_tv_records_media_list
get_tv_status

Support for the tv api
Improve method names
@stilllman stilllman self-requested a review September 16, 2019 21:24
@stilllman stilllman self-assigned this Sep 16, 2019
Copy link

@stilllman stilllman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, adding this API would definitely be interesting! 😃

I have mostly the same comments as I made for PR #12: make sure the calls to Access are correct, and use the appropriate naming for the parameters.

aiofreepybox/aiofreepybox.py Show resolved Hide resolved
Fix instantiate module
Rename parameters
Fix calls
Fix missing underscore
aiofreepybox/aiofreepybox.py Outdated Show resolved Hide resolved
Fix instantiate for good.
Missed it again ! thx @SNoof85
Cosmetics fixes
@foreign-sub foreign-sub changed the title Add support for the tv api Add support for the tv API Sep 18, 2019
Copy link
Member

@SNoof85 SNoof85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could maybe define a default value for bouquet_id to freeboxtv then it would replace the async def get_tv_default_bouquet_channels(self):

aiofreepybox/api/tv.py Outdated Show resolved Hide resolved
Copy link

@stilllman stilllman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what all these functions do, but everything seems correct except maybe the use of time.time(), which returns the number of seconds since the epoch. Maybe this is really what the API expect, in which case I'm ok for merging!

aiofreepybox/api/tv.py Show resolved Hide resolved
@stilllman stilllman merged commit 80f6b77 into hacf-fr:aiofreepybox Oct 1, 2019
@foreign-sub foreign-sub deleted the add-tv-api branch October 2, 2019 07:10
@oncleben31 oncleben31 added the enhancement New feature or request label Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants