-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the tv API #13
Conversation
Support for the tv api
Improve method names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request, adding this API would definitely be interesting! 😃
I have mostly the same comments as I made for PR #12: make sure the calls to Access
are correct, and use the appropriate naming for the parameters.
Fix instantiate module
Rename parameters
Fix calls
Fix missing underscore
Fix instantiate for good. Missed it again ! thx @SNoof85
Cosmetics fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could maybe define a default value for bouquet_id
to freeboxtv
then it would replace the async def get_tv_default_bouquet_channels(self):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what all these functions do, but everything seems correct except maybe the use of time.time()
, which returns the number of seconds since the epoch. Maybe this is really what the API expect, in which case I'm ok for merging!
Support for the freebox os tv API
Api calls:
get_finished_tv_records
get_tv_bouquet_channels
get_tv_bouquet
get_tv_channels
get_tv_default_bouquet_channels
get_tv_program
get_tv_program_highlights
get_tv_programs_by_channel
get_tv_programs_by_date
create_tv_record
create_tv_record_generator
edit_tv_record_generator
get_tv_record_generator
get_tv_records_configuration
get_tv_records_media_list
get_tv_status