Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline setup for aarch64-linux #9326

Open
wants to merge 55 commits into
base: main
Choose a base branch
from
Open

Pipeline setup for aarch64-linux #9326

wants to merge 55 commits into from

Conversation

sajjaphani
Copy link
Contributor

@sajjaphani sajjaphani commented Jul 23, 2024

The hab* packages are rebuilt against LTS-2024 and uploaded to the SaaS builder (version 1.6.1178). These temporarily built artifacts are used by the verification pipeline for building and testing purposes.

Copy link

netlify bot commented Jul 23, 2024

👷 Deploy Preview for chef-habitat processing.

Name Link
🔨 Latest commit 5866c8c
🔍 Latest deploy log https://app.netlify.com/sites/chef-habitat/deploys/6733796e19148700089beaa1

Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: Phani Sajja <psajja@progress.com>
@@ -38,6 +38,15 @@ steps:
environment:
- BUILD_PKG_TARGET=x86_64-linux

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove the [:linux: build hab (ARM)] build above?

agents:
queue: default-privileged-aarch64
env:
HAB_FALLBACK_CHANNEL: "lts24-aarch64-linux"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this channel into LTS-2024?

command:
- sudo -E .expeditor/scripts/release_habitat/package_and_upload_binary.sh
if: build.creator.name == 'Chef Expeditor' || build.env("UPLOAD_AND_PROMOTE") == 'true'

- label: "[:linux: :two: upload hab binary]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a ARM :docker: Upload containers to Docker Hub too right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Will do that in a seperate PR!

export rustc_target="x86_64-unknown-linux-musl"
# With the musl target, the ring crate is looking for aarch64-linux-musl-gcc,
# but the core/musl package provides musl-gcc. This workaround is necessary until the appropriate changes are made to core/musl for aarch64.
if [[ "${pkg_target%%-*}" == "aarch64" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think this is something that needs to be changed in the aarch64 core/musl package itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will raise a PR in core-packages as it requires some work. Once those changes are in place, I can update this.

package_path=${1?package_path argument required}

# Install hab from a temporarily uploaded aarch64 package
curl https://raw.githubusercontent.com/habitat-sh/habitat/main/components/hab/install.sh | sudo bash -s -- -t "$BUILD_PKG_TARGET" -c "$HAB_FALLBACK_CHANNEL" -v 1.6.1178
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we just put this package in stable and not need to rely on a specific build number? I don't see a problem with that since we have not publicized arm support and it wouldn't be possible for customers to see it on the official downloads site.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged, I am thinking of updating the channel to dev to build the latest hab and update the pipeline. If that doesn’t work, I can promote the build created by the release pipeline and then update it here.

Signed-off-by: Phani Sajja <psajja@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants