allow older user tokens to succesfully authenticate #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… errors Signed-off-by: Matt Wrock <matt@mattwrock.com>
Signed-off-by: Matt Wrock <matt@mattwrock.com>
mwrock
changed the title
Signed-off-by: Matt Wrock <matt@mattwrock.com>
chef-expeditor bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add some tracing code that helped to troubleshoot and identify the underlying cause of 401s authenticating to builder with generated user tokens.
From the comments:
// Prior to the chronos update 4 months ago this is the max timestamp used for user tokens
// We have succesfully parsed this value via the call to Utc.timestamp_opt above for years
// Yesterday (2024-09-12), this value became out of bounds and yields a 401 trying to auth
// Right now we have no idea why and some day perhaps we will all laugh around the fire as
// we remember this bug and how trivial it truly was. Today no one is laughing. I hope there
// will be a better fix than this in the near future but this will allow the many keys currently
// out in the wild with this value to authenticate.
That sadly is close to all I know right now.