Removed connected_plans from backend #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sougata-progress <sougatab@progress.com>
|
hi @mwrock i have removed the logic for the functions i could find, which i think are related to connected plans. please let me know if there are any other functions that are related to this ex. create_job, etc, as i couldn't figure out if the other functions are needed or not. |
There was a problem hiding this comment.
In addition to the comments mentioned, you may want to look at the following files and possibly update/remove
test/builder-api/src/origin.js- Fix 'project' related test cases.- possibly comment out a few tests in
test/builder-api/project.jsor may be comment out this file intest/builder-api/api.jswith a//TODOadded - Likely following functions in
app/actions/gitHub.tsare not required as well - (because they were being used only in theproject.ts)*githubInstallationsand*githubRepositories. This might be a good time to remove those.
Signed-off-by: sougata-progress <sougatab@progress.com>
Signed-off-by: sougata-progress <sougatab@progress.com>
Signed-off-by: sougata-progress <sougatab@progress.com>
Signed-off-by: sougata-progress <sougatab@progress.com>
sougata-progress
force-pushed
the
sougata/remove_connected_plans
branch
2 times, most recently
from
435fe3e
to
d36c53d
Compare
mwrock
reviewed
Aug 8, 2024
sougata-progress
force-pushed
the
sougata/remove_connected_plans
branch
4 times, most recently
from
6508b3b
to
e379c94
Compare
Signed-off-by: sougata-progress <sougatab@progress.com>
sougata-progress
force-pushed
the
sougata/remove_connected_plans
branch
from
e379c94
to
57d8a20
Compare
Signed-off-by: sougata-progress <sougatab@progress.com>
Signed-off-by: sougata-progress <sougatab@progress.com>
mwrock
requested changes
Aug 12, 2024
Signed-off-by: sougata-progress <sougatab@progress.com>
sougata-progress
force-pushed
the
sougata/remove_connected_plans
branch
from
fb14bb1
to
3fb8be5
Compare
|
hi @mwrock I have made the requested changes |
mwrock
approved these changes
Aug 12, 2024
chef-expeditor bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
story : CHEF-12418