allow an Access-Control-Allow-Origin header to be set for certain oauth providers like automate #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th providers like automate Signed-off-by: Matt Wrock <matt@mattwrock.com>
chef-expeditor bot
pushed a commit
that referenced
this pull request
Dec 22, 2022
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really to compensate for recent changes in the automate oauth flow. If using a modern automate for oauth, the CORS headers need to be set. This introduces a new config setting:
allow_oauth_origin. If a user is using automate as an oauth provider, they can set this setting to the domain of their automate server:https://my.automate.server.com.We will update the
install.shof the on-prem builder to do this automatically.Signed-off-by: Matt Wrock matt@mattwrock.com