Fix picking the pkg target for fully qualified ident #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phani Sajja <psajja@progress.com>
mwrock
approved these changes
Feb 8, 2022
Signed-off-by: Phani Sajja <psajja@progress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we do not supply the target parameter for a package, it will default to X86_64_Linux. However, if the input ident is fully qualified, the builder determines the correct target when finding a package.
Sample route:
/v1/depot/pkgs/neurosis/testapp/0.1.4/20181115124506
After identifying the package, the target property from the newly found package should be used instead of the default.
Signed-off-by: Phani Sajja psajja@progress.com