Skip to content

Qt5 to 6#12

Draft
haakov wants to merge 85 commits intomainfrom
qt5to6
Draft

Qt5 to 6#12
haakov wants to merge 85 commits intomainfrom
qt5to6

Conversation

@haakov
Copy link
Owner

@haakov haakov commented Feb 6, 2025

Draft PR to keep track of the changes

dl1ksv and others added 29 commits February 10, 2025 04:31
Right-clicking in the canvas now brings up a context menu on a selected block.
If multiple blocks are selected the context menu is assoziated to th 'first' block
in the list. If no block is selected a message appears.

If the mouse is over a block this block will be selected.

Fixes gnuradio#7610

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
Lintian found spelling errors: lenght -> length, errror -> error.
Fix also changes BINDTOOL_HEADER_FILE_HASH of interleaver.h.

Signed-off-by: A. Maitland Bottoms <bottoms@debian.org>
When designing RFNoC bitfiles for X440, the radio clock ports need to be
differently named (X440 has clocks `radio0` and `radio1`, X410 only has
a `radio` clock).

Signed-off-by: Martin Braun <martin.braun@ettus.com>
Signed-off-by: Jean-Michel Friedt <friedtj@free.fr>
Glen Langstom contributed this theme; I asked him whether it'd be OK to
include it:

> Hi Marcus,
>
> Thanks again for your help and all your efforts with Gnuradio.
>
> I’m perfectly fine with anyone’s use of that file.
>
> Please add whatever license you think is appropriate.
>
> Best regards
>
> Glen

So, I included the file with the appropriate GPLv3 OR MIT-0 license, so
that anyone might use it.

Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Signed-off-by: Zaky Hermawan <zaky.hermawan9615@gmail.com>
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
This became necessary as removing the precompiled headers unearthed a
fail of pagesize.cc to compile. While working through the `windows.h`
includes, other show-stoppers occurred (like including windows.h in the
middle of a constructor), so I fixed them.

Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
it's separate.

Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Fixes Github gnuradio#7752

Signed-off-by: Nathan West <nathan@quadrature.dev>
The resampler regularly read input beyond what was available, because d_resamp.interpolate needs ntaps() amount of samples.

I had unify mmse_{resampler,fir_interp}_{cc,ff} into templates.

This became necessary because I didn't want to manually duplicate
my fixes to mmse_resampler_cc to mmse_resampler_ff.

Less code, less maintenance, fewer bugs.
… passing.

Signed-off-by: Jimmy Fitzpatrick <jcfitzpatrick12@gmail.com>
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
as found through applying clang-tidy

Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
as found through applying clang-tidy

Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
This fixes a rare corner case seen in unit tests, where multiple tests
interfere with one another on the sys.stdout messenger.

Signed-off-by: Martin Braun <martin.braun@ettus.com>
Includes autopep8 fixes and fixing imports.

Co-authored-by: Martin Braun <martin.braun@ettus.com>
Signed-off-by: ZakyHermawan <zaky.hermawan9615@gmail.com>
Signed-off-by: Martin Braun <martin.braun@ettus.com>
Old XML-based GRC files don't necessarily provide output_language, but
they only supported Python anyway, so we auto-populate that field.

Signed-off-by: Martin Braun <martin.braun@ettus.com>
New checks! Actually found bugs with the RAII checker.

Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
When generating a flow graph, we make the generator aware if it's being
called directly, or implied by "execute". This can be useful for future
workflows.

Signed-off-by: Martin Braun <martin.braun@ettus.com>
These functions are GUI-independent, and should therefore go into
a non-widget-specific location.

Signed-off-by: Martin Braun <martin.braun@ettus.com>
Signed-off-by: Håkon Vågsether <hakon.vagsether@gmail.com>
This allows to use all FEC encoders and decoders by just creating
corresponding encoder and decoder objects in Python and without
creating a flowgraph

Signed-off-by: Andrej Rode <mail@andrejro.de>
In the previous version of GRC, workflows were hard-coded. There was C++
vs.  Python, with and without Qt, as hier block or as top block. This
changeset enables a different paradigm: All workflows are now available
as plugins. By default, GNU Radio supports all workflows that were
previously hardcoded (see list above, plus gr-bokeh_gui with Python).

A major part of this changeset is the updated Options block. The YAML
for the Options block no longer lists all the available workflows.
Rather, there is a Python-based implementation of the Options block,
which will dynamically load all workflows it can find.

Co-authored-by: Martin Braun <martin.braun@ettus.com>
Signed-off-by: ZakyHermawan <zaky.hermawan9615@gmail.com>
Signed-off-by: Martin Braun <martin.braun@ettus.com>
Signed-off-by: Håkon Vågsether <hakon.vagsether@gmail.com>
By definition, pybind has to bind even deprecated functions (until we
actually remove them).

So, erroring out when we do that is not an option.

Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
This adds a new output language and build options to GRC and allows
building RFNoC FPGA bitfile straight out of GNU Radio.

Signed-off-by: Martin Braun <martin.braun@ettus.com>
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
marcusmueller and others added 29 commits June 19, 2025 22:27
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
- Fix formatting that makes it harder for Doxygen to operate
- Improve comment on use_even_carriers

Signed-off-by: Martin Braun <martin.braun@ettus.com>
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Add CMake so that -DTRY_QT6_BUILD=ON will try a Qt6 build.
Otherwise, gnuradio will build using Qt5.
"Try" because without qwt being Qt6 aware, the build will fail.
This is a first step towards Qt6 using gnuradio.

Signed-off-by: A. Maitland Bottoms <bottoms@debian.org>
Signed-off-by: Håkon Vågsether <hakon.vagsether@gmail.com>
Signed-off-by: Håkon Vågsether <hakon.vagsether@gmail.com>
Signed-off-by: Håkon Vågsether <hakon.vagsether@gmail.com>
Signed-off-by: Håkon Vågsether <hakon.vagsether@gmail.com>
Signed-off-by: Håkon Vågsether <hakon.vagsether@gmail.com>
Signed-off-by: Håkon Vågsether <hakon.vagsether@gmail.com>
Signed-off-by: Håkon Vågsether <hakon.vagsether@gmail.com>
Signed-off-by: Håkon Vågsether <hakon.vagsether@gmail.com>
Signed-off-by: Håkon Vågsether <hakon.vagsether@gmail.com>
Signed-off-by: Håkon Vågsether <hakon.vagsether@gmail.com>
Signed-off-by: Håkon Vågsether <hakon.vagsether@gmail.com>
…tion

Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>

Radar

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
We don't offer any tooling to do exactly the right formatting in the
IDE.
Having to wait for CI just to see it not even run because your IDE and
pycodestyle (of an old version) disagree on something is not conductive
to code quality, overall.

I'm leaving the check in, and we'll see failures and need people to fix
them. But let's not gate ourselves from progress this much.

Proposal would probably be to actually pick a tool that integrates with
IDEs well, or at least is foolsafe to run manually, and base the check
on that.

Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.