-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename main.css to style.css in build process #2342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please make the suggested changes. Thanks so much.
CHANGELOG.md
Outdated
@@ -1,5 +1,9 @@ | |||
# Changelog | |||
|
|||
## 9.0.0 (TBD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this. I have an open PR with a line for these changes, I'll link to your PR when it's merged in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I was relying with this change on what you did in #2341. I think in general this kind of thing should be done on release branch(?) ➡️ Reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
General
Reference: #2339
Description:
style.css
package.json
after runningnpm run build
CHANGELOG.md
Types of changes
Checklist
Additional notes
As I noticed, the styling for boilerplate come from the NPM Package called main.css and it seems to be a bit confusing on a first look. Since that package is strongly connected to this project, we might consider:
@
symbol) e.g.: @html5-boilerplate/stylingPull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.
Thanks!