Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename main.css to style.css in build process #2342

Merged
merged 7 commits into from
Sep 28, 2020

Conversation

sthiepaan
Copy link
Contributor

@sthiepaan sthiepaan commented Sep 27, 2020

General

Reference: #2339
Description:

  • Change CSS output file name to style.css
  • Fix test against CSS file
  • Update documentation after output file rename
  • Bump package.json after running npm run build
  • Documents change in CHANGELOG.md

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Additional notes

As I noticed, the styling for boilerplate come from the NPM Package called main.css and it seems to be a bit confusing on a first look. Since that package is strongly connected to this project, we might consider:

  • rename it to something that will not affect filename e.g.: html5-boilerplate-styling
  • reorganize repositories to use scoped packages (with @ symbol) e.g.: @html5-boilerplate/styling

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.

Thanks!

Copy link
Member

@roblarsen roblarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please make the suggested changes. Thanks so much.

CHANGELOG.md Outdated
@@ -1,5 +1,9 @@
# Changelog

## 9.0.0 (TBD)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this. I have an open PR with a line for these changes, I'll link to your PR when it's merged in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I was relying with this change on what you did in #2341. I think in general this kind of thing should be done on release branch(?) ➡️ Reverted

dist/doc/css.md Outdated Show resolved Hide resolved
src/doc/TOC.md Outdated Show resolved Hide resolved
src/doc/css.md Outdated Show resolved Hide resolved
dist/doc/TOC.md Outdated Show resolved Hide resolved
Copy link
Member

@roblarsen roblarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants