Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant rules from .editorconfig #2157

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Conversation

coliff
Copy link
Member

@coliff coliff commented Sep 9, 2019

This removes the unnecessary:

[{.travis.yml,package.json}]
# The indent size used in the `package.json` file cannot be changed
# https://github.com/npm/npm/pull/3180#issuecomment-16336516
indent_size = 2
indent_style = space

The preceding rules state indent size of 2 and spaces anyway. (plus that linked GitHub issue regarding package.json has been fixed as of npm 5)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coliff coliff requested a review from roblarsen September 9, 2019 04:09
@coliff coliff mentioned this pull request Sep 9, 2019
6 tasks
@roblarsen roblarsen merged commit 60beb6f into master Oct 14, 2019
@coliff coliff deleted the editorconfig-rules branch October 15, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants