fix(node): trigger abort signal when body read is done #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for POST requests, 'close' on req is emitted when the HTTP message has been fully received, NOT when the connection closed
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
I have added better tests to show current Bun/Deno/Node behavior: #123 -- currently, Node (HTTP1/HTTP2) and Deno behavior are consistent. As a result of this PR, we would be introducing a new inconsistency that the Node.js adapter (only in HTTP1 mode) emits fewer (13 => 6) abort events and in HTTP2 mode, behaves same. |
pi0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for POST requests, 'close' on req is emitted when the HTTP message has been fully received, NOT when the connection closed
fixes TanStack/router#4271