Skip to content

fix: handle Headers when merging proxy headers #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025

Conversation

kricsleo
Copy link
Member

@kricsleo kricsleo commented Apr 22, 2025

resolves #865

This backports the fix to v1. (see #1026 for v2)
If it's not needed, feel free to close it. ❤️

@kricsleo kricsleo changed the title fix: handle Headers when merging proxy headers fix: handle Headers when merging proxy headers Apr 22, 2025
@pi0 pi0 added the v1 label Apr 22, 2025
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/utils/proxy.ts 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pi0 pi0 merged commit 397cefa into h3js:v1 Apr 24, 2025
4 checks passed
@kricsleo kricsleo deleted the fix/v1-merge-headers branch April 24, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants