Skip to content

Angular 17 #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Angular 17 #371

wants to merge 4 commits into from

Conversation

belugasanity
Copy link

Still testing locally but I hope this can give a decent start to the next update.

Copy link

@Klaster1 Klaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating without resolving #357 makes little sense, how about trying to fix that? I'd start by figuring out how to import the theming bits the Material 16.20 release broke. As a last resort, I guess new styles can be authored, using mdc style tokens.

@AdamsContreras999
Copy link

@Klaster1 please can you check this branch if is possible updated to angular 17.

@Klaster1
Copy link

@AdamsContreras999 not sure I follow you here. While changes in the PR do in fact make the "angular-material-components" compatible with Angular 17 (I did the same here), I doubt this would be sufficient given the #357 remains unresolved. I am not "angular-material-components" maintainer and like most people watching the PR, have a couple of projects where Angular 17 is blocked by issues outlined above.

@Sergiobop
Copy link

Sergiobop commented Dec 5, 2023

This problem happens every six months, since this package takes too long to update to the major versions. For Angular 16 some issues like "Is this repo abandoned?" popped up.

Maybe it's more "useful" for now to update the package.json to >= 16 to avoid future blocks like this¿?

As a workaround, i added this to my package.json and it just works:

  "overrides": {
    "@angular-material-components/datetime-picker": {
      "@angular/platform-browser": ">=16.0.0",
      "@angular/common": ">=16.0.0",
      "@angular/core": ">=16.0.0",
      "@angular/forms": ">=16.0.0",
      "@angular/material": ">=16.0.0",
      "@angular/cdk": ">=16.0.0"
    },
    "@angular-material-components/moment-adapter": {
      "@angular/common": ">=16.0.0",
      "@angular/core": ">=16.0.0"
    }
  }

@LanderBeeuwsaert
Copy link

@Sergiobop perfect! works like a charm

@MatthewLHolden
Copy link

MatthewLHolden commented Dec 17, 2023

@Sergiobop - Nice one!

I've added the above to the overrides object. Added the HTML and receive the following console error. I've tried installing animations v16 without luck. Any ideas at all please?

Unexpected synthetic property @transitionMessages found. Please make sure that:
  - Either `BrowserAnimationsModule` or `NoopAnimationsModule` are imported in your application.
  - There is corresponding configuration for the animation named `@transitionMessages` defined in the `animations` field of the `@Component` decorator (see https://angular.io/api/core/Component#animations).

Although, in the meantime, I'm trying this: https://github.com/danielmoncada/date-time-picker as I can't wait around too long for this update.

@LcsGa
Copy link

LcsGa commented Jan 18, 2024

Hi! Is there some news about this PR?

1 similar comment
@BetynMineiro
Copy link

Hi! Is there some news about this PR?

@kupchic
Copy link

kupchic commented Apr 23, 2024

Hi! we are looking forward to this update

@Afzalraza235
Copy link

Hi,
When this Angular 17 support is expected?

@Sergiobop
Copy link

Angular 18 is just around the corner. Sadly, updates in this package are not expected

Maybe we should try to fork and maintain a different repo..

@MeadAlsorani
Copy link

any news guys???
Angular 19 is almost here and we are struggling to work with the 17th 🤦‍♂️

@Sergiobop
Copy link

Sergiobop commented Aug 19, 2024

any news guys??? Angular 19 is almost here and we are struggling to work with the 17th 🤦‍♂️

Check this PR. Updated to Angular 18, and working almost without bugs:
#393

@fouratachour
Copy link

Angular 19 is almost here !!
guys ! we need moreee reactivity here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.