-
Notifications
You must be signed in to change notification settings - Fork 177
Angular 17 #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Angular 17 #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating without resolving #357 makes little sense, how about trying to fix that? I'd start by figuring out how to import the theming bits the Material 16.20 release broke. As a last resort, I guess new styles can be authored, using mdc style tokens.
@Klaster1 please can you check this branch if is possible updated to angular 17. |
@AdamsContreras999 not sure I follow you here. While changes in the PR do in fact make the "angular-material-components" compatible with Angular 17 (I did the same here), I doubt this would be sufficient given the #357 remains unresolved. I am not "angular-material-components" maintainer and like most people watching the PR, have a couple of projects where Angular 17 is blocked by issues outlined above. |
This problem happens every six months, since this package takes too long to update to the major versions. For Angular 16 some issues like "Is this repo abandoned?" popped up. Maybe it's more "useful" for now to update the package.json to >= 16 to avoid future blocks like this¿? As a workaround, i added this to my package.json and it just works:
|
@Sergiobop perfect! works like a charm |
@Sergiobop - Nice one! I've added the above to the
Although, in the meantime, I'm trying this: https://github.com/danielmoncada/date-time-picker as I can't wait around too long for this update. |
Hi! Is there some news about this PR? |
1 similar comment
Hi! Is there some news about this PR? |
Hi! we are looking forward to this update |
Hi, |
Angular 18 is just around the corner. Sadly, updates in this package are not expected Maybe we should try to fork and maintain a different repo.. |
any news guys??? |
Check this PR. Updated to Angular 18, and working almost without bugs: |
Angular 19 is almost here !! |
Still testing locally but I hope this can give a decent start to the next update.