Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow dynamic change of table selection #2445 #2452

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Conversation

marek-mihok
Copy link
Contributor

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

Screen.Recording.2025-03-24.at.13.37.09.mov

Closes #2445

@marek-mihok marek-mihok requested review from lo5 and mturoci as code owners March 24, 2025 12:39
Copy link
Collaborator

@sulhicader sulhicader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You @marek-mihok for looking into the issue.

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @marek-mihok!

@mturoci mturoci merged commit d39112d into main Mar 31, 2025
5 checks passed
@mturoci mturoci deleted the fix/issue-2445 branch March 31, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When We updating the values attribute of a wave table, rows selection in the UI are not updating accordingly
3 participants