-
Notifications
You must be signed in to change notification settings - Fork 342
feat: Improved handle_on alternative #1484. #2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mturoci tested on windows, but doesn't seem to work (no prints): cmd_40xXcon9lZ.mp4edit: seems to be another more general issue: q.args is always empty. any idea why? (python 3.11 .. can that be an issue?) |
No issues under linux. Def. better than handle_on behavior imho. One thing, empty textbox and toggles will still not work (even tho its not directly related to this PR I think)
|
Yep, didn't manage to add it yesterday. Will do today. Thanks for the feedback @Far0n! |
Interesting, will have a look. |
Windows fixed and zip updated in the PR description. @Far0n give it a try please and let me know if all is ok. It should now also include fixed for falsy values not triggering. |
yep, now both work. |
6d8c34b
to
73313cf
Compare
73313cf
to
6fc1e9c
Compare
Introduces a new
run_on
that is an alternative to the currenthandle_on
with a more intuitive behavior.Main features
False
or''
- this was a bug in the originalhandle_on
.# routing
to regular interactions (btns, etc.) as well.Testing code
#1480 works as expected as well.
linux.zip
macosx.zip
win.zip
cc @Far0n @vopani @pascal-pfeiffer for feedback
Naming suggestions highly welcome!
Closes #1484
Closes #1008