-
Notifications
You must be signed in to change notification settings - Fork 97
Add InMemoryDatasets.jl #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
InMemoryDatasets.jl is a new package for data manipulation in Julia.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks very good. Just to let you know that I am no longer maintaining the project (although I am happy to provide the feedback) and the best way to have your PR merged and run is, I believe, contacting h2o.ai support. Project is inactive for a longer while but I haven't heard anything about it to be abandoned. Looking forward to see benchmark results.
@@ -0,0 +1,58 @@ | |||
using Printf; # sprintf macro to print in non-scientific format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIU this file could be shared between juliadf and juliads. As we do for pyton and R tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMD
uses DLMReader
for writing the log file, however, DataFrames.jl
uses CSV
. So one possible way to combine these is to have different write_log
functions in the same file.
using DLMReader; | ||
using PooledArrays | ||
|
||
IMD.warmup() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have a comment what this warm up actually do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment for this.
Thanks for your feedback. I have made some changes based on your comments. |
InMemoryDatasets.jl is a new package for data manipulation in Julia. Please let me know if anything is wrong.