Handle unlabelled ts files #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 15, 2022 22:03
The ts file format doesn't require labels to be defined. If they aren't defined then it returns the dataset only. If they are defined in the file, then then return is a tuple of the data and the labels. So test the return value and handle the two cases.
If no labels are defined in the file, then this variable is no initialised and causes an error at runtime.
gzerveas
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this code and the paper!
I found an issue when working with the ts file format - if I was using unlabelled data and so defined
@classlabel falsein the header section of the file then it would throw an exception when running. The issue is that the return fromload_from_tsfile_to_dataframewill return a tuple when@classlabelistrue, but just the dataframe when@classlabelisfalse. Therefore, when unpacking the expected fromload_from_tsfile_to_dataframeit would throw an exception, and fall back to your implementation, however this assumes that the last column is a label and you end up with a truncated data set.