Move pretty-printing into the crate, gated by a feature #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
rust-cpuid
in Humility to decode CPU features, and it has been great!The pretty-printing code currently in
src/bin/cpuid.rs
would be very helpful as library code, since we'd like pretty-printing but don't want to call an external binary.This PR moves that pretty-printing code into a new module (
display
) in the crate itself. This module is gated by thedisplay
feature; by default, it's off and the crate is stillno_std
. If you enable that feature, then you have access to theraw_cpuid::display
module, which exposes those nice pretty-printing functions.(there's also a bit of feature wrangling to make the
cli
feature enabledisplay
, etc, but nothing too weird)