Skip to content

[BUG]Code comment inconsistency #804

@YichiZhang0613

Description

@YichiZhang0613

Describe the bug
In cursive-new-main/cursive-core/src/event.rs, the comment indicates that code should be panic when n == 0 while the code would not.

/// # Panics
    ///
    /// If `n == 0 || n > 12`
    pub fn from_f(n: u8) -> Key {
        match n {
            0 => Key::F0,
            1 => Key::F1,
            2 => Key::F2,
            3 => Key::F3,
            4 => Key::F4,
            5 => Key::F5,
            6 => Key::F6,
            7 => Key::F7,
            8 => Key::F8,
            9 => Key::F9,
            10 => Key::F10,
            11 => Key::F11,
            12 => Key::F12,
            _ => panic!("unknown function key: F{n}"),
        }
    }

To Reproduce
Key::from_f(0); That will not panic.

Expected behavior
The code should be consistent with comment.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions