Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Update Stepper inner text components and colors #776

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

ericcleao
Copy link
Member

JIRA Issue

Description 📄

The Stepper started to use new colors from the theme instead of global colors and the new Text.Outline as the Label, matching future theme updates.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

  • Add v3theme support at both doc and labnative environments (maintaining current default theming);

  • Build normally;

  • Check current and v3theme designs

  • Unit Test

  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

environment screenshot
web image
native image

@ericcleao ericcleao self-assigned this Mar 21, 2024
@ericcleao ericcleao added enhancement New feature or request @gympass/yoga and removed @gympass/yoga labels Mar 21, 2024
@ericcleao ericcleao requested review from evilamaior and a team March 21, 2024 18:36
@evilamaior evilamaior merged commit 7764a37 into master Mar 22, 2024
3 checks passed
@evilamaior evilamaior deleted the CIB-265 branch March 22, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request @gympass/yoga
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants