Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS-783] - Fix inconsistencies in the text component #754

Merged
merged 8 commits into from
Mar 8, 2024
Merged

Conversation

evilamaior
Copy link
Contributor

@evilamaior evilamaior commented Mar 7, 2024

JIRA Issue

Description 📄

  • Fix inconsistencies in the text component
  • <Text.Body1> is the new <Text>
  • <Text.Body2> is the new <Text.Small>
  • <Text.Caption> is the new <Text.Tiny>
  • Create <Text.Overline>
  • Add bold prop for cases like <Text.H1 bold> or <Text.Body1 bold> (the design team will indicate when to use the prop)

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

Run all environments (iOS, Android, and Web). The Text pages should include the new components.

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

Typography
image
image

Text

Web iOS Android
image image Screenshot_1709849931

<Text.Caption>Caption</Text.Caption>
<Text.Overline>Overline</Text.Overline>
<Text.SectionTitle>SectionTitle</Text.SectionTitle>
<Text.SmallestException>SectionTitle</Text.SmallestException>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here should be SmallestException, right?

Esthefanie Vila Maior added 2 commits March 8, 2024 17:29
@evilamaior evilamaior merged commit 8e013e2 into master Mar 8, 2024
3 checks passed
@evilamaior evilamaior deleted the DS-783 branch March 8, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants