Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parentStackingContext of elements inside a ShadowRoot #17

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

edenilan
Copy link

@edenilan edenilan commented Nov 2, 2021

parentStackingContext of elements inside a ShadowRoot is not necessarily "html"

@edenilan edenilan mentioned this pull request Nov 2, 2021
@gwwar
Copy link
Owner

gwwar commented Nov 2, 2021

Thanks for the PR @edenilan and looking over the related specs! I think the behavior here makes sense, I tried testing this against the MDN example at https://developer.mozilla.org/en-US/docs/Web/Web_Components/Using_shadow_DOM

CleanShot.2021-11-02.at.09.43.28.mp4

I also did a spot check for other stacking behavior, and it looks okay.

CleanShot.2021-11-02.at.09.46.00.mp4

I'll release a new version shortly, after looking to see if there's any other misc CSS stacking rules that should be updated.

@gwwar gwwar merged commit ed4b37c into gwwar:master Nov 2, 2021
@gwwar
Copy link
Owner

gwwar commented Nov 2, 2021

I've submitted the extension for review 🤞 that it's won't take too long. In the meantime, if it's urgent folks can clone this repository and click on "load unpacked" and point it at the checkout folder.

CleanShot 2021-11-02 at 11 56 59

@gwwar
Copy link
Owner

gwwar commented Nov 4, 2021

This fix should now be available in v1.1.0 from https://chrome.google.com/webstore/detail/z-context/jigamimbjojkdgnlldajknogfgncplbh 🎉 Thanks again for the contribution @edenilan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants