fix: elements with position sticky also form a stacking context
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [MDN web docs][1], elements with position `sticky` also form a stacking context, this adds an additional check to contemplate this case. [1]: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Positioning/Understanding_z_index/The_stacking_context
roperzh
force-pushed
the
fix-position-sticky
branch
from
bd9255d to
3611d5f
Compare
|
Thanks @roperzh! Sorry for the super late response, I need to update my notification settings on GitHub. :D I'll try and do a latest update pass on rules soon and will include your contribution in the next update! |
gwwar
approved these changes
May 6, 2019
|
haha no worries, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the MDN web docs, elements with position
stickyalsoform a stacking context, this adds an additional check to contemplate
this case.