Repository navigation
validate language subtag in GwtLocale fromString #10368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Samin061
wants to merge
3
commits into
gwtproject:main
Choose a base branch
from
Samin061:gwtlocale-language-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+105
−1
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /* | ||
| * Copyright 2026 GWT Project Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package com.google.gwt.testing.server; | ||
|
|
||
| /** | ||
| * Assertion helpers for server-side JUnit 3 tests, where the JUnit 4/5 | ||
| * {@code assertThrows} is not available. | ||
| */ | ||
| public class Assertions { | ||
|
|
||
| /** | ||
| * A block of code that may throw any {@link Throwable}, so it can be passed to | ||
| * {@link #assertThrows} as a lambda. | ||
| */ | ||
| public interface Executable { | ||
| void execute() throws Throwable; | ||
| } | ||
|
|
||
| /** | ||
| * Asserts that running {@code executable} throws an exception of | ||
| * {@code expectedType} (or a subtype) and returns it, failing with | ||
| * {@code message} if nothing is thrown or a different type is thrown. | ||
| */ | ||
| public static <T extends Throwable> T assertThrows(Class<T> expectedType, | ||
| Executable executable, String message) { | ||
| try { | ||
| executable.execute(); | ||
| } catch (Throwable actual) { | ||
| if (expectedType.isInstance(actual)) { | ||
| return expectedType.cast(actual); | ||
| } | ||
| throw new AssertionError(message + " but threw " + actual, actual); | ||
| } | ||
| throw new AssertionError(message); | ||
| } | ||
|
|
||
| private Assertions() { | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still in a client package despite being in a package named "server" - tests are failing, but only the one suite that uses the
testingpackageWorth nothing, this isnt "server" code anyway, just jvm code, but if you want a class like this, it needs to be in a non-client package. Or, if you are okay with it working in GWT too, get rid of the isInstance/cast usage so reflection isn't required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the point of the class was the Jupiter-equivalent semantics for JVM tests, I kept isInstance/cast and took the package out of the translatable path instead: TestUtils.gwt.xml now excludes server/** from its source, so the GWT compiler no longer sees it and the suite that inherits the testing module compiles again. Can move it to a different package outright if you'd rather not carry the exclude.