Repository navigation
Raise Java language level to 17, update errorprone, asm - #10336
Conversation
|
Depends on gwtproject/tools#39 |
|
Converted to draft while moving new APIs to triage and waiting for tools merge. |
|
CollectReferencesVisitorTest failure is due to asm version being 9.6 - the test only passes up to Java 22. This doesn't impact the compiler actually working, but is a failure specific to the test reading Object.clas. CompilationUnitTypeOracleUpdaterFromByteCodeTest has a similar problem, though it is designed to read bytecode from JDT's output, which is currently limited to a max of java 17. The test however still grabs Object.class, as above, which will be specific to whatever JRE is actually running the test. |
zbynek
left a comment
There was a problem hiding this comment.
(Just noting that the tools repo branch reference needs to be reverted here.)
Otherwise looks good 👍
ErrorProne version is raised to the newest release that still supports running on Java 17. There are however two bugs in EP that cause it to fail when compiling GWT with this release - these are fixed in 2.45, so a workaround is applied for now. Several classes were also updated to address new EP violations.
The asm version is also updated to latest, and confirmed to work on Java 17, and should be forward compatible to Java 27.