Skip to content

Raise Java language level to 17, update errorprone, asm - #10336

Merged
niloc132 merged 14 commits into
gwtproject:mainfrom
niloc132:min-java17
Jun 24, 2026
Merged

niloc132 merged 14 commits into
gwtproject:mainfrom
niloc132:min-java17

Conversation

@niloc132

@niloc132 niloc132 commented Jun 8, 2026 •

Copy link
Copy Markdown
Member

ErrorProne version is raised to the newest release that still supports running on Java 17. There are however two bugs in EP that cause it to fail when compiling GWT with this release - these are fixed in 2.45, so a workaround is applied for now. Several classes were also updated to address new EP violations.

The asm version is also updated to latest, and confirmed to work on Java 17, and should be forward compatible to Java 27.

@niloc132 niloc132 added this to the 2.14 milestone Jun 8, 2026
@niloc132

niloc132 commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

Depends on gwtproject/tools#39

@niloc132
niloc132 marked this pull request as draft June 8, 2026 19:23
@niloc132

niloc132 commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

Converted to draft while moving new APIs to triage and waiting for tools merge.

@niloc132 niloc132 mentioned this pull request Jun 8, 2026
@niloc132 niloc132 added the ready This PR has been reviewed by a maintainer and is ready for a CI run. label Jun 9, 2026
@niloc132
niloc132 marked this pull request as ready for review June 9, 2026 12:07
@niloc132

niloc132 commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

CollectReferencesVisitorTest failure is due to asm version being 9.6 - the test only passes up to Java 22. This doesn't impact the compiler actually working, but is a failure specific to the test reading Object.clas.

CompilationUnitTypeOracleUpdaterFromByteCodeTest has a similar problem, though it is designed to read bytecode from JDT's output, which is currently limited to a max of java 17. The test however still grabs Object.class, as above, which will be specific to whatever JRE is actually running the test.

@niloc132 niloc132 changed the title Raise Java language level to 17, update errorprone Raise Java language level to 17, update errorprone, asm Jun 10, 2026

@zbynek zbynek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Just noting that the tools repo branch reference needs to be reverted here.)

Otherwise looks good 👍

@niloc132
niloc132 requested a review from zbynek June 24, 2026 16:10
@niloc132
niloc132 merged commit eb7fc83 into gwtproject:main Jun 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready This PR has been reviewed by a maintainer and is ready for a CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants