Skip to content

Add permissions for publishing JUnit report - #10169

Merged
zbynek merged 1 commit into
mainfrom
zbynek-patch-1
Oct 29, 2025
Merged

zbynek merged 1 commit into
mainfrom
zbynek-patch-1

Conversation

@zbynek

@zbynek zbynek commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

Based on suggestion in https://github.com/mikepenz/action-junit-report?tab=readme-ov-file#pr-run-permissions

Recent PRs marked as ready run the JUnit step, but are missing the report because of permissions. This PR should fix that.

@zbynek zbynek added the ready This PR has been reviewed by a maintainer and is ready for a CI run. label Oct 27, 2025
@niloc132

Copy link
Copy Markdown
Member

Note that for reviewdog, we follow the other path, and use annotations instead. The linked doc indicates that this action also supports creating annotations for failed tests:

        with:
          annotate_only: true # forked repo cannot write to checks so just do annotations

@zbynek

zbynek commented Oct 28, 2025

Copy link
Copy Markdown
Collaborator Author

Annotations are great if the annotated files are part of the PR (always the case with checkstyle), but I'm not sure it's possible to use them in case of failing unit tests that didn't change (which is the case for most? test failures).

@niloc132

Copy link
Copy Markdown
Member

That's a great point - and it looks like stack traces are lost in annotations too: mikepenz/action-junit-report#1278

@zbynek
zbynek merged commit db6f61c into main Oct 29, 2025
13 checks passed
@niloc132

niloc132 commented Nov 6, 2025

Copy link
Copy Markdown
Member

Looks like these still aren't working:
https://github.com/gwtproject/gwt/actions/runs/19096338630?pr=10176
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready This PR has been reviewed by a maintainer and is ready for a CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants