Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Window.onClosing() not work in GWT 2.12 #10101

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Fix Window.onClosing() not work in GWT 2.12 #10101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix Window.onClosing() not work in GWT 2.12 (#10074) 
When Window.onClosing(), if beforeCloseHandlersInitialized (not
closeHandlersInitialized) is true, fire the ClosingEvent.

Fixes #10072.
  • Loading branch information
@InforBG @niloc132
InforBG authored and niloc132 committed Feb 26, 2025
commit 8bd23e416b2c1998578eb89d409787e367a8d671
2 changes: 1 addition & 1 deletion user/src/com/google/gwt/user/client/Window.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,7 @@ static void onClosed() {
}

static String onClosing() {
if (closeHandlersInitialized) {
if (beforeCloseHandlersInitialized) {
Window.ClosingEvent event = new Window.ClosingEvent();
fireEvent(event);
return event.getMessage();
Expand Down