Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update getting started (use gwt-maven-archetype) #354

Merged
merged 19 commits into from
Jan 9, 2024
Merged

update getting started (use gwt-maven-archetype) #354

merged 19 commits into from
Jan 9, 2024

Conversation

FrankHossfeld
Copy link
Member

No description provided.

@FrankHossfeld FrankHossfeld mentioned this pull request Dec 18, 2023
Open
niloc132
niloc132 reviewed Dec 23, 2023
View reviewed changes
src/main/markdown/gettingstarted-outdated.md Outdated
@@ -0,0 +1,162 @@
Getting Started
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool URIs don't change - If we're moving the old content to a new page, we should link it from the "current" one, otherwise this page isn't going to be easy to find for those who could need it. On the other hand, if we think we should just entirely remove it, let's remove it, rather than keeping it but hard to find.

I don't think it would be unreasonable to keep the old contents on the existing page either, but all the way at the bottom with a "deprecated" header (so that old anchors could still work)?

I'm not sure if I have a preference from the three choices... probably "move to new page, but link it properly, with a plan to delete in the future", but only a very mild preference.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. Missed it.

src/main/markdown/gettingstarted-outdated.md Outdated Show resolved Hide resolved
src/main/markdown/gettingstarted.md Outdated
rel="nofollow">from Adopt OpenJDK</a> for your platform.
2. Apache Ant is also necessary to run command line arguments in this sample. If
you don't already have it, install <a href="http://ant.apache.org/" rel="nofollow">Apache Ant</a>.
1. You will need the Java SDK version 11 or later. If necessary, download and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GWT 2.11 still supports running and building in Java 8, but we encourage newer builds.

src/main/markdown/gettingstarted.md Outdated Show resolved Hide resolved
src/main/markdown/gettingstarted.md Outdated Show resolved Hide resolved
src/main/markdown/using-intellij.md Outdated

### Code Server Run Configuration

Press `edit configuration`, a popup appears. Now press `+` and select `Maven`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Press `edit configuration`, a popup appears. Now press `+` and select `Maven`.
Press `Edit Configuration`, a popup appears. Now press `+` and select `Maven`.

src/main/markdown/using-intellij.md Outdated

Press `edit configuration`, a popup appears. Now press `+` and select `Maven`.

Enter `gwt:codeserver -pl mywebapp-client -am` in the field under run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Enter `gwt:codeserver -pl mywebapp-client -am` in the field under run:
Enter `gwt:codeserver -pl mywebapp-client -am` in the field under `Run`:

src/main/markdown/using-intellij.md Outdated

<div class="screenshot"><a href="images/intellij-run-code-server.png"><img src="images/intellij-run-code-server.png" alt="Screenshot" width="42%"/></a></div>

Now, you have a run configuration, that starts the code server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Now, you have a run configuration, that starts the code server.
Now you have a run configuration that starts the code server.

src/main/markdown/using-intellij.md Outdated

Now, you have a run configuration, that starts the code server.

Note: you have to use the module name instead of '*'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to substitute the * above? It makes more sense below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added more text to clearify

src/main/markdown/using-intellij.md Outdated

### Server Run Configuration

Press `edit configuration`, a popup appears. Now press `+` and select `Maven`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Press `edit configuration`, a popup appears. Now press `+` and select `Maven`.
Press `Edit Configuration`, a popup appears. Now press `+` and select `Maven`.

@niloc132
Copy link
Contributor

This seems to conflict with #349 - do you want to close that one?

@FrankHossfeld FrankHossfeld mentioned this pull request Dec 27, 2023
Closed
FrankHossfeld and others added 5 commits December 27, 2023 12:59
@FrankHossfeld @niloc132
Update src/main/markdown/gettingstarted-outdated.md
47d3e9d 
Co-authored-by: Colin Alworth <colin@vertispan.com>
@FrankHossfeld @niloc132
fixed typo
911e66d 
Co-authored-by: Colin Alworth <colin@vertispan.com>
@FrankHossfeld @niloc132
add Linux
034049e 
Co-authored-by: Colin Alworth <colin@vertispan.com>
@FrankHossfeld
review feedback
1f30bf1
@FrankHossfeld
Merge remote-tracking branch 'origin/getting-started-v2' into getting…
ddabd4b 
…-started-v2
@FrankHossfeld FrankHossfeld mentioned this pull request Dec 27, 2023
Open
@FrankHossfeld @niloc132
update IntelliJ set up
305cf16 
Co-authored-by: Colin Alworth <colin@vertispan.com>
@FrankHossfeld
Copy link
Member Author

This seems to conflict with #349 - do you want to close that one?

Yes, it conflicts. I closed it.

@niloc132 niloc132 mentioned this pull request Jan 8, 2024
Merged
niloc132
niloc132 reviewed Jan 8, 2024
View reviewed changes
src/main/markdown/gettingstarted.md Outdated
@@ -55,7 +58,7 @@ run and use the SDK are located in the extracted directory.

## Create your first web application<a id="create"></a>

GWT ships with a command line utility called [webAppCreator](https://www.gwtproject.org/doc/latest/RefCommandLineTools.html#webAppCreator) that automatically generates all the files you'll need in order to start a GWT project. It also generates [Eclipse](http://www.eclipse.org/) project files and launch config files for easy debugging in GWT's development mode.
GWT ships with a command line utility called [webAppCreator](http://www.gwtproject.org/doc/latest/RefCommandLineTools.html#webAppCreator) that automatically generates all the files you'll need in order to start a GWT project. It also generates [Eclipse](http://www.eclipse.org/) project files and launch config files for easy debugging in GWT's development mode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GWT ships with a command line utility called [webAppCreator](http://www.gwtproject.org/doc/latest/RefCommandLineTools.html#webAppCreator) that automatically generates all the files you'll need in order to start a GWT project. It also generates [Eclipse](http://www.eclipse.org/) project files and launch config files for easy debugging in GWT's development mode.
GWT ships with a command line utility called [webAppCreator](https://www.gwtproject.org/doc/latest/RefCommandLineTools.html#webAppCreator) that automatically generates all the files you'll need in order to start a GWT project. It also generates [Eclipse](https://www.eclipse.org/) project files and launch config files for easy debugging in GWT's development mode.

src/main/markdown/learnmore-sdk.md Outdated
@@ -111,8 +111,8 @@ GWT is free, and all of the [code](https://gwt.googlesource.com/) is available u

## Ready to get started?

<a href="gettingstarted.html">
<a href="*arted.html">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="*arted.html">
<a href="gettingstarted-v2.html">

niloc132
niloc132 reviewed Jan 8, 2024
View reviewed changes
src/main/markdown/gettingstarted-v2.md
Now, you generate a new application project by using the following command:

```
mvn archetype:generate \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe adopt the note about forcing a new version of this plugin, so you don't get extra newlines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing my changes ..

@niloc132 niloc132 merged commit d4ee371 into gwtproject:main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niloc132 niloc132 niloc132 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankHossfeld @niloc132