-
Notifications
You must be signed in to change notification settings - Fork 49
Updated composite site files to include 2.12.2 sdk #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@niloc132: I checked the plugin compatibility with the latest eclipse version, and found, that gwt 2.12.2 is not in the list of SDKs to install. |
| <child location='https://plugins.gwtproject.org/eclipse/gwt-eclipse-plugin/latest'/> | ||
| <child location='https://plugins.gwtproject.org/eclipse/gwt-sdk-plugins/latest'/> | ||
| </children> | ||
| type='org.eclipse.equinox.internal.p2.artifact.repository.CompositeArtifactRepository' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit more than adding 2.12.2 SDK.
What is the value added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to the modification is not well chosen.
But I hope that the sense is ok: you're switching to an enumeration of all SDK versions instead of the latest SDK version.
I'm sure that it makes sense, but I'd appreciate if you could clarify,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is made to allow the user to install one of the SDKs Versions instead of only the latest.
The File on the Server already contains the List (without 2.12.2). This here just make it match with
https://plugins.gwtproject.org/eclipse/site/latest/compositeContent.xml
https://plugins.gwtproject.org/eclipse/site/latest/compositeArtifacts.xml
and adds 2.12.2.
|
Maybe this belongs instead over here? Vertispan/gwtproject.org#16 |
If that's the source for the then i agree. |
No description provided.