Skip to content

Conversation

@keinhaar
Copy link
Contributor

No description provided.

@keinhaar
Copy link
Contributor Author

keinhaar commented Nov 7, 2025

@niloc132: I checked the plugin compatibility with the latest eclipse version, and found, that gwt 2.12.2 is not in the list of SDKs to install.
Would you please review this, and then update these 2 files on the update site here:
https://plugins.gwtproject.org/eclipse/site/latest/

<child location='https://plugins.gwtproject.org/eclipse/gwt-eclipse-plugin/latest'/>
<child location='https://plugins.gwtproject.org/eclipse/gwt-sdk-plugins/latest'/>
</children>
type='org.eclipse.equinox.internal.p2.artifact.repository.CompositeArtifactRepository'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit more than adding 2.12.2 SDK.
What is the value added?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to the modification is not well chosen.
But I hope that the sense is ok: you're switching to an enumeration of all SDK versions instead of the latest SDK version.
I'm sure that it makes sense, but I'd appreciate if you could clarify,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is made to allow the user to install one of the SDKs Versions instead of only the latest.
The File on the Server already contains the List (without 2.12.2). This here just make it match with
https://plugins.gwtproject.org/eclipse/site/latest/compositeContent.xml
https://plugins.gwtproject.org/eclipse/site/latest/compositeArtifacts.xml
and adds 2.12.2.

@niloc132
Copy link
Member

Maybe this belongs instead over here? Vertispan/gwtproject.org#16

@keinhaar
Copy link
Contributor Author

Maybe this belongs instead over here? Vertispan/gwtproject.org#16

If that's the source for the

https://plugins.gwtproject.org/eclipse/site/latest

then i agree.
I had added this here to have a version saved in the project itself.
I were not aware of that Vertispan repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants