Skip to content

Conversation

eagoetz
Copy link
Collaborator

@eagoetz eagoetz commented Mar 16, 2023

This fixes a problem where the "Quiet" and "Noisy" states were undefined in time, so the whole duration was used. This meant there was no distinction between the states as plotted for the summary pages.

A metastate would be defined as

[metastate-Quiet]
key = Quiet
name = SEI Quiet
uses = H1-quiet,L1-quiet

[state-H1-Quiet]
name = SEI Quiet
key = H1-quiet
hours = 1-5,H1

[state-L1-Quiet]
name = SEI Quiet
key = L1-quiet
hours = 2-6,L1

It is not super robust in that it's really only supposed to be used for combining some interval for H1 and some interval for L1. I'm not sure it's really ready to be heavily used in many situations

Addresses the comment in #358

@eagoetz eagoetz changed the title Added a new "metastate" section type where one can combine states fro… Added a new "metastate" section type where one can combine states from different detecrtors Mar 16, 2023
@eagoetz eagoetz changed the title Added a new "metastate" section type where one can combine states from different detecrtors Added a new "metastate" section type where one can combine states from different detectors Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #363 (77d68ed) into master (48150d1) will increase coverage by 0.01%.
The diff coverage is 60.98%.

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   50.29%   50.30%   +0.01%     
==========================================
  Files          60       60              
  Lines        8665     8699      +34     
==========================================
+ Hits         4358     4376      +18     
- Misses       4307     4323      +16     
Flag Coverage Δ
Linux 50.30% <60.98%> (+0.01%) ⬆️
python3.10 50.30% <60.98%> (+0.01%) ⬆️
python3.7 49.50% <60.00%> (+0.01%) ⬆️
python3.8 50.30% <60.98%> (+0.01%) ⬆️
python3.9 50.30% <60.98%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gwsumm/plot/builtin.py 21.57% <20.00%> (-0.16%) ⬇️
gwsumm/tabs/data.py 31.01% <44.44%> (-0.03%) ⬇️
gwsumm/state/core.py 51.11% <81.25%> (+2.94%) ⬆️
gwsumm/config.py 94.42% <100.00%> (+0.05%) ⬆️
gwsumm/state/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…m different detectors

This fixes a problem where the "Quiet" and "Noisy" states were undefined in time, so the whole duration was used. This meant there was no distinction between the states as plotted for the summary pages.

A metastate would be defined as
```
[metastate-Quiet]
key = Quiet
name = SEI Quiet
uses = H1-quiet,L1-quiet

[state-H1-Quiet]
name = SEI Quiet
key = H1-quiet
hours = 1-5,H1

[state-L1-Quiet]
name = SEI Quiet
key = L1-quiet
hours = 2-6,L1
```

It is not super robust in that it's really only supposed to be used for combining some interval for H1 and some interval for L1. I'm not sure it's really ready to be heavily used in many situations

Addresses the comment in gwpy#358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant