Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Lib/test/test_genericalias.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,17 @@ def test_exposed_type(self):
self.assertIs(a.__origin__, list)
self.assertEqual(a.__parameters__, (int,))

def test_isinstance(self):
self.assertTrue(isinstance([], list))
with self.assertRaises(TypeError):
isinstance([], list[str])

def test_issubclass(self):
class L(list): ...
self.assertTrue(issubclass(L, list))
with self.assertRaises(TypeError):
issubclass(L, list[str])


if __name__ == "__main__":
unittest.main()
18 changes: 18 additions & 0 deletions Objects/descrobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -1946,8 +1946,26 @@ ga_mro_entries(PyObject *self, PyObject *args)
return PyTuple_Pack(1, alias->origin);
}

static PyObject *
ga_instancecheck(PyObject *self, PyObject *Py_UNUSED(ignored))
{
return PyErr_Format(PyExc_TypeError,
"TypeError: Subscripted generics cannot be used with class and instance checks",
self);
}

static PyObject *
ga_subclasscheck(PyObject *self, PyObject *Py_UNUSED(ignored))
{
return PyErr_Format(PyExc_TypeError,
"TypeError: Subscripted generics cannot be used with class and instance checks",
self);
}

static PyMethodDef ga_methods[] = {
{"__mro_entries__", ga_mro_entries, METH_O},
{"__instancecheck__", ga_instancecheck, METH_O},
{"__subclasscheck__", ga_subclasscheck, METH_O},
{0}
};

Expand Down