remove magic trimming of URI component delimiters#83
Merged
mtdowling merged 3 commits intoguzzle:masterfrom May 18, 2016
Tobion:uri-delimiters
Merged
remove magic trimming of URI component delimiters#83mtdowling merged 3 commits intoguzzle:masterfrom Tobion:uri-delimiters
mtdowling merged 3 commits intoguzzle:masterfrom
Tobion:uri-delimiters
Conversation
Member
|
The other PR is merged. Can you rebase? |
…f component delimiters, improve encoding tests
Member
Author
|
Done |
Member
Author
|
@mtdowling ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #81 and will be rebased when #81 is merged.
withHostdidn't check the type for example, butwithPathdid. AndwithQuerychecked for__toStringwhich is not specified in PSR-7.++) to prevent regex backtracking which improves performance