Skip to content

Fix Utils::modifyRequest dropping ServerRequest attributes #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nyholm merged 1 commit into from
Mar 21, 2021
Merged

Fix Utils::modifyRequest dropping ServerRequest attributes #400

Nyholm merged 1 commit into from
Mar 21, 2021

Conversation

@GrahamCampbell
Copy link
Member

@GrahamCampbell GrahamCampbell commented Mar 21, 2021

Fixes #344.

@GrahamCampbell @ImadBazzal
Fix Utils::modifyRequest dropping ServerRequest attributes
d1b8b6d 
Fixes #344

Co-Authored-By: Imad Bazzal <12641890+ImadBazzal@users.noreply.github.com>
Nyholm
Nyholm approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@GrahamCampbell
Copy link
Member Author

GrahamCampbell commented Mar 21, 2021

Better wait for CI before merging. I've not run the tests locally. :trollface:

@Nyholm
Copy link
Member

Nyholm commented Mar 21, 2021

I've not run the tests locally.

I've spent all this time setting up CI... Im rarely running the tests locally.

@GrahamCampbell
Copy link
Member Author

GrahamCampbell commented Mar 21, 2021

CI green now. :)

@GrahamCampbell GrahamCampbell added this to the 1.8.1 milestone Mar 21, 2021
@Nyholm Nyholm merged commit aa50bd7 into 1.x Mar 21, 2021
@Nyholm
Copy link
Member

Nyholm commented Mar 21, 2021

Thank you

@Nyholm Nyholm deleted the retain-attributes branch March 21, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@GrahamCampbell @Nyholm