Adding tests for BC checks #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not make this the same checks.yml as in guzzle/guzzle? |
I didnt think of it more than that. |
GrahamCampbell
approved these changes
Mar 21, 2021
Nyholm
added a commit
that referenced
this pull request
Mar 21, 2021
* Soft-final all classes that are final in 2.x (#385) * Adding integration tests (#390) * fix: seek stream cloned from php input to begining (#382) * fix: seek stream cloned from php input to begining * Update CI Co-authored-by: Nyholm <tobias.nyholm@gmail.com> * Locale independent URL parsing (#386) Co-Authored-By: Alexey Shokov <alexey@shockov.com> Co-authored-by: Alexey Shokov <alexey@shockov.com> * Adding tests for BC checks (#393) * Prepare release 1.8.0 (#394) * Prepare release 1.8.0 * Update CHANGELOG.md * Remove period * Fixes post-merge Co-authored-by: Tobias Nyholm <tobias.nyholm@gmail.com> Co-authored-by: Aleh Hutnikau <hutnikau@1pt.com> Co-authored-by: Alexey Shokov <alexey@shockov.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make sure we dont break things accidentally.