Skip to content

Tests failing randomly #7

Closed
Closed
@guyzmo

Description

@guyzmo

The tests are failing since the introduction of the --progress support. The issue being inconsistent failing of the same code between calls. Cf the travis reports.

With a fair bit of debugging, I found out the issue is that because GitPython relies on the kwargs construct to pass around optional arguments, the order of argument will depend on the order of the items within the dict. As when I introduced progress support, opt_arg contains '-v' and '--progress' now, the order depending on both hash('-v') and hash('--progress'). To fix this, making the optional arguments ordered on their value instead on their hash will do the job, but sadly it's not something that can be fixed with a tiny bit of monkey patching…

Thus, I've opened a PR upstream at gitpython-developers/GitPython#431 with a very simple fix for that.

Metadata

Metadata

Assignees

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions