Update pdf_generator.ex

[edipox]

Add html_file to the returned value.

Use case: someone wants to remove the html temporary file

[gutschilla]

@edipox Thanks for your PR! Usually one shouldn't care about temporary files (your OS should do) so explicit deleting isn't usually necessary.

On the other hand there's no real reason not to be able to delete that file but I'd rather see an option to the call than changing it's return value signature from a 2-element tuple to a 3-element tuple as this would surely break someone's code (at least mine) when pattern-matching the result of generate as in

{:ok, file} = PdfGenerator.generate(...)

So I'd rather suggest an option delete_temporay: :html that does just that.

Tell what you think

[edipox]

Yeah, you are totally right. I didn't think about code breaking issues.

This is my situation: pdf generation per concurrent request. So I can't let the OS delete the files, because it could be too late and the disk space could end. And I can't delete all the .html files after each request because another request could be reading a file while I am deleting it.
But your suggestion will work perfectly!
Thank you

[edipox]

@gutschilla I did what you suggested. Could you take a look?

[gutschilla]

That could be rewritten as

if Keyword.get(options, :delete_temporary) == :html do
   File.rm html_file
end

In my opinion, no need for a nil -> nil case

[gutschilla]

Thanks a lot for your patch and thanks as well for removing all these spaces at line endings. Would you please take a look at my small-ish line comment?

[edipox]

@gutschilla Done!
The end line spaces were removed by this Atom package: https://github.com/atom/whitespace each time you save a file the package remove spaces at line endings automatically

[gutschilla]

Beautiful! Thanks a lot for your contribution!