Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: union types with camelCase #10

Merged
merged 2 commits into from
Oct 1, 2023
Merged

fix: union types with camelCase #10

merged 2 commits into from
Oct 1, 2023

Conversation

jly36963
Copy link
Contributor

@jly36963 jly36963 commented Sep 30, 2023 •
edited
Loading

Relates to #9

Description

Extending unknown prevents the camel-case mapping from being distributive over the union type, and instead it transforms all elements in the same way.

@jly36963 jly36963 marked this pull request as ready for review September 30, 2023 20:47
@gustavoguichard
Copy link
Owner

Amazing!! Thank you SO much for the contribution!
I wonder if there are other string transformations that might be affected by the same bug. I'll investigate that and see if I can bring this solution to lower level function such as "words"

@gustavoguichard
Copy link
Owner

As I spoke to @jly36963 it seems to be a problem only with camelCase.
I'll merge it now and publish the fix soon.
Appreciate the contribution 🙌

@gustavoguichard gustavoguichard merged commit 4a08eab into gustavoguichard:main Oct 1, 2023
@jly36963 jly36963 deleted the union-camel-fix branch October 3, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jly36963 @gustavoguichard