Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new command to show Pull Request details #629

Merged
merged 2 commits into from
Dec 14, 2016

Conversation

shulard
Copy link
Member

@shulard shulard commented Aug 23, 2016

We have for the moment a issue:show, I think having a pull-request:show is nice too. It's the same logic than for issue :

  • It display general details / description
  • A flag --with-comments allow to display comments
  • Add tests

@cordoval
Copy link
Member

add description txt with a checkbox for add test

@sstok sstok added the WIP label Oct 24, 2016
@shulard
Copy link
Member Author

shulard commented Dec 14, 2016

Hello,

I've just added a test to validate command execution. This command will be able to dump PullRequest details like :

Pull Request #10 - Write a behat test to launch strategy by weaverryan [open]
=============================================================================

 Org/Repo:         gushphp/gush
 Link:             https://github.com/gushphp/gush/pull/10
 Labels:           actionable, easy pick
 Milestone:        some_good_stuff
 Assignee:         cordoval
 Source => Target: cordoval/gush#head_ref => gushphp/gush#base_ref

Body
----

 Help me conquer the world. Teach them to use Gush.

This PR is ready for a review.

@cordoval
Copy link
Member

bump @shulard please rebase so i can review

thanks

@shulard
Copy link
Member Author

shulard commented Dec 14, 2016

I've just rebased on master.

@cordoval cordoval merged commit 0525ccf into gushphp:master Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants