Do not mutate user-supplied opts (stripe#1041)

gurus00 · Oct 14, 2020 · bbefa30 · bbefa30
1 parent 54c99ed
commit bbefa30
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/lib/utils.js b/lib/utils.js
@@ -149,7 +149,7 @@ const utils = (module.exports = {
       if (typeof arg === 'string') {
         opts.auth = args.pop();
       } else if (utils.isOptionsHash(arg)) {
-        const params = args.pop();
+        const params = {...args.pop()};
 
         const extraKeys = Object.keys(params).filter(
           (key) => !OPTIONS_KEYS.includes(key)

diff --git a/test/makeRequest.spec.js b/test/makeRequest.spec.js
@@ -0,0 +1,29 @@
+'use strict';
+
+require('../testUtils');
+
+const makeRequest = require('../lib/makeRequest');
+const expect = require('chai').expect;
+
+describe('makeRequest', () => {
+  describe('args', () => {
+    it('does not mutate user-supplied deprecated opts', () => {
+      const args = [
+        {
+          stripe_account: 'bad',
+        },
+      ];
+      const mockSelf = {
+        createResourcePathWithSymbols: () => {},
+        createFullPath: () => {},
+        _request: () => {},
+      };
+      makeRequest(mockSelf, args, {}, {});
+      expect(args).to.deep.equal([
+        {
+          stripe_account: 'bad',
+        },
+      ]);
+    });
+  });
+});