Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalculateAverage_gonixunsafe: an attempt in the unsafe category #695

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

gonix
Copy link
Contributor

@gonix gonix commented Jan 31, 2024

Wanted to work on this a bit more, but since I've already been working on it, trying to get in the last minute before the deadline :-)

Check List:

  • You have run ./mvnw verify and the project builds successfully
  • Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
  • All formatting changes by the build are committed
  • Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
  • Output matches that of calculate_average_baseline.sh
  • For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)
    • Comparing the key for equality in lines: 360, 369-374, 381-393
  • Execution time: ~1.1s
  • Execution time of reference implementation: ~145s
  • Machine: Intel i7-11800H @ 2.30GHz (max 4.6GHz), 8 cores (16 threads), 32GB RAM

@gunnarmorling
Copy link
Owner

00:02.507.

@gunnarmorling gunnarmorling merged commit 540ef2c into gunnarmorling:main Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants