Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EduardoSaverin #689

Merged
merged 2 commits into from
Feb 1, 2024
Merged

EduardoSaverin #689

merged 2 commits into from
Feb 1, 2024

Conversation

EduardoSaverin
Copy link
Contributor

UserName : EduardoSaverin
Total Time : 15.408
CPU : 8 Core (Apple M1 Pro)
RAM : 16GB
Collision Handling Line Number : 122
Output Checked by running and matching calculate_average_baseline.sh

Check List:

  • You have run ./mvnw verify and the project builds successfully
  • Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
  • All formatting changes by the build are committed
  • Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
  • Output matches that of calculate_average_baseline.sh
  • For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number : 122)

Execution Times on my machine

  • Execution time: 15.408 Sec
  • Execution time of reference implementation: 16.347 Sec

UserName : EduardoSaverin
Total Time : 15.408
CPU : 8 Core (Apple M1 Pro)
RAM : 16GB
@gunnarmorling
Copy link
Owner

Fails a test when running on 32 cores of the eval machine:

+ timeout -v 300 ./test.sh EduardoSaverin
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-10000-unique-keys.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-10.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-1.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-20.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-2.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-3.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-boundaries.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-complex-utf8.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-dot.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-rounding.txt
2c2
< jel;-9.0;17.4;46.5
---
> jel;-9.0;18.0;46.5

FAILURE: ./test.sh EduardoSaverin failed
Summary
  EduardoSaverin: command failed or output did not match

Removed ConcurrentHashMap with Reentrant Lock + HashMap. Since multiple threads causing problems.
@EduardoSaverin
Copy link
Contributor Author

@gunnarmorling
Hi,
Sorry for this, but it seems when I ran this it worked fine. I looked upon this problem and found it was sometimes causing issue. Now I have fixed this can you please again run this on 32 Cores.

@gunnarmorling
Copy link
Owner

Looking good now: 00:05.336.

@gunnarmorling gunnarmorling merged commit e7c9209 into gunnarmorling:main Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants