-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit earlier from loop when a new Result is created #668
Exit earlier from loop when a new Result is created #668
Conversation
A bit slower now:
|
e0ab6f6
to
14b1319
Compare
Thank you @gunnarmorling ! I made some changes. Could you please run it again? |
Still slower:
|
* 3) Make a cache of long[] name to String, to avoid `ByteBuffer.allocate` * and creating new UTF-8 strings. I didn't profile, so it's just a guess * that this map will be a bit faster. Although it's outside the main loop, so * not a big difference ...; * 4) Exit earlier from loop if a new entry was created.
As I was not able to make it faster ... so I'll make it slower, because my current solution should *not* stay at the top, as it added basically nothing.
14b1319
to
3990783
Compare
The new code will be slower, but you can merge it this way, no problem. Thanks a lot for 1brc! I think #1brc will be the best thing for Java in 2024, and we're just in January!!! =D |
00:02.995 now for the standard key set. Amongst the top for 10K (I'll update that leaderboard later this week):
Thank you so much, I really appreciate it! Thanks for participating in 1BRC and congrats on creating one of the top entries! |
Hey @tivrfoa! Congrats again on being in the Top 20 of the One Billion Row Challenge! To celebrate this amazing achievement, I would like to send you a 1BRC t-shirt and coffee mug. To claim your prize, fill out this form by Feb 18. After submitting the form, please provide a comment with the random value you've specified in the form, so that I know it is you who submitted it. All data entered will solely be used in relation to processing this shipment. Shipments can be sent to any country listed here or here (I'll use whichever one is cheaper for me to ship to your location). A big thank you to Decodable for sponsoring these prizes! Thanks a lot for participating in 1BRC, --Gunnar |
32228 24253 Thank you! 😄 |
Check List:
./mvnw verify
and the project builds successfully./test.sh <username>
shows no differences between expected and actual outputs)calculate_average_<username>.sh
(make sure to match casing of your GH user name) and is executablecalculate_average_baseline.sh