fixed clippy warning

.cargo/config

@@ -0,0 +1,2 @@
+[alias]
+arch01 = "run -- run -n arch01"

Cargo.toml

@@ -7,3 +7,4 @@ edition = "2018"
 [dependencies]
 nix = "0.11.0"
 getopts = "0.2"
+dirs = "1.0"

src/bootstrap.rs

@@ -3,7 +3,7 @@ use std::process::Command;
 pub fn pacstrap(container_path: &str) {
     let mut pacstrap = Command::new("pacstrap")
         .arg("-i")
-        .arg(format!("{}", container_path))
+        .arg(container_path.to_string())
         .arg("base")
         .arg("base-devel")
         .arg("dnsutils")

src/cli.rs

@@ -5,7 +5,9 @@ use std::process;
 use std::process::exit;
 
 use nix::sched::{unshare, CloneFlags};
-use nix::unistd::{chdir, chroot, getpgid, getuid, Pid, Uid};
+use nix::unistd::{chdir, chroot, getpgid, getuid, Pid};
+
+use dirs::home_dir;
 
 use super::bootstrap::pacstrap;
 use super::container;
@@ -20,7 +22,7 @@ pub fn run(args: &[String]) {
 
     let ace_container_path_env = "ACE_CONTAINER_PATH";
     // TODO: settting.rsからの読み込みに変更
-    let home_dir = env::home_dir().expect("Cannot get $HOME");
+    let home_dir = home_dir().expect("Cannot get $HOME");
     let ace_path = format!("{}/{}", home_dir.display(), "ace-containers");
     env::set_var(ace_container_path_env, ace_path);
 

src/container.rs

@@ -24,10 +24,10 @@ impl Container {
 
         Container {
             name: name.clone(),
-            path: path,
-            command: command,
-            uid: uid,
-            pgid: pgid,
+            path,
+            command,
+            uid,
+            pgid,
             network: initialize_network(name),
         }
     }

src/network.rs

@@ -48,15 +48,9 @@ impl Bridge {
     }
 
     pub fn existed(&self) -> bool {
-        let addrs = nix::ifaddrs::getifaddrs().unwrap();
-        let ifname = addrs
-            .into_iter()
-            .filter(|ifaddr| ifaddr.interface_name == self.name)
-            .next();
-        match ifname {
-            Some(_) => true,
-            None => false,
-        }
+        let mut addrs = nix::ifaddrs::getifaddrs().unwrap();
+        let ifname = addrs.find(|ifaddr| ifaddr.interface_name == self.name);
+        ifname.is_some()
     }
 }
 
@@ -69,11 +63,11 @@ impl Network {
         container_ip: IpAddr,
     ) -> Network {
         Network {
-            namespace: namespace,
-            bridge: bridge,
-            veth_host: veth_host,
-            veth_guest: veth_guest,
-            container_ip: container_ip,
+            namespace,
+            bridge,
+            veth_host,
+            veth_guest,
+            container_ip,
             pid: process::id(),
         }
     }
@@ -129,15 +123,9 @@ impl Network {
     }
 
     pub fn existed_veth(&self) -> bool {
-        let addrs = nix::ifaddrs::getifaddrs().unwrap();
-        let ifname = addrs
-            .into_iter()
-            .filter(|ifaddr| ifaddr.interface_name == self.veth_host)
-            .next();
-        match ifname {
-            Some(_) => true,
-            None => false,
-        }
+        let mut addrs = nix::ifaddrs::getifaddrs().unwrap();
+        let ifname = addrs.find(|ifaddr| ifaddr.interface_name == self.veth_host);
+        ifname.is_some()
     }
 
     pub fn add_container_network(&self) -> Result<(), ()> {