Skip to content

Support/Ignore build pre-release label and build metadata #3

Closed
@amblp

Description

@amblp

Hi - Since the fancy-log module started to use parse-node-version, we are seeing the following error when running gulp:

17:42:35 + npm test
17:42:35 
17:42:35 > my-app@1.0.0 test /path/to/test
17:42:35 > gulp
17:42:35 
17:42:35 /path/to/test/node_modules/parse-node-version/index.js:6
17:42:35     throw new Error('Unable to parse: ' + version);
17:42:35     ^
17:42:35 
17:42:35 Error: Unable to parse: v10.15.0+0-b20181231T20014594
17:42:35     at parseNodeVersion (/path/to/test/node_modules/parse-node-version/index.js:6:11)
17:42:35     at Object.<anonymous> (/path/to/test/node_modules/fancy-log/index.js:7:48)
17:42:35     at Module._compile (internal/modules/cjs/loader.js:689:30)
17:42:35     at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
17:42:35     at Module.load (internal/modules/cjs/loader.js:599:32)
17:42:35     at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
17:42:35     at Function.Module._load (internal/modules/cjs/loader.js:530:3)
17:42:35     at Module.require (internal/modules/cjs/loader.js:637:17)
17:42:35     at require (internal/modules/cjs/helpers.js:22:18)
17:42:35     at Object.module.exports [as log] (/path/to/test/node_modules/gulp-util/lib/log.js:10:20)

As you can see, this module fails to parse "v10.15.0+0-b20181231T20014594"
We're using a version of node that has been built with the --tag option (https://github.com/nodejs/node/blob/55e0ad9ae690f6d73b0caff7b813eb4d61195b94/configure.py#L330-L333).

The pre-release label and build metadata (as per semver.org) would need to be either ignored, or parsed appropriately.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions