Skip to content

upgrade Orchestrator to 0.2.0 and use hrDuration -- a process.hrtime() #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2013

Conversation

robrich
Copy link
Contributor

@robrich robrich commented Dec 6, 2013

No description provided.

@yocontra
Copy link
Member

yocontra commented Dec 6, 2013

Can you update gulp-util prettyTime to support the new format?

@robrich
Copy link
Contributor Author

robrich commented Dec 6, 2013

I started into it, and figured that might be better as a separate module. node-timeago is intriguingly similar but totally different. Basically turn an hrtime into a descriptive time including optionally rounding it to a sane amount of decimal digits. In theory, execify could just fill meta with the pretty desc, and gulp could just output it -- provided you're ok with the number and units being the same color. What do you think?

@yocontra
Copy link
Member

yocontra commented Dec 6, 2013

Yep that's totally fine

I just want something like 1.2s, 200ms, 500μs, etc.

Figuring out where to draw the line is hard but somebody has probably already done it before

@yocontra
Copy link
Member

yocontra commented Dec 6, 2013

@robrich Also sounds like a great module! (prettifying hrtimes)

@robrich
Copy link
Contributor Author

robrich commented Dec 9, 2013

How's this?

@yocontra
Copy link
Member

yocontra commented Dec 9, 2013

LGTM

yocontra added a commit that referenced this pull request Dec 9, 2013
upgrade Orchestrator to 0.2.0 and use hrDuration -- a process.hrtime()
@yocontra yocontra merged commit 6deb0dd into gulpjs:master Dec 9, 2013
@yocontra
Copy link
Member

yocontra commented Dec 9, 2013

Do you know when hrtime came about? I might need to adjust the version reqs

@robrich
Copy link
Contributor Author

robrich commented Dec 9, 2013

I read in a node release notes that it appeared in 0.7.6, though true-to-form, I can't find it now. As gulp is >=0.8, we should be fine.

@robrich
Copy link
Contributor Author

robrich commented Dec 9, 2013

... and true to form, moments after pushing send I find it: http://nodejs.org/changelog.html then search for process.hrtime()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants