Skip to content

Remove references to description configuration property #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

folliehiyuki
Copy link

The description option in .gulp.* configuration file is never read.

@phated
Copy link
Member

phated commented Jun 1, 2025

It looks like I never removed the docs for the description property when converting everything to the translation code. I think we'll probably just remove the docs since we want all of the message logic to go through the translation mechanism.

Do you want to update this PR to remove those docs?

@folliehiyuki
Copy link
Author

Is it just in the README? Some test files still use exports.description (https://github.com/gulpjs/gulp-cli/blob/master/test/fixtures/config/foo/bar/quux/.gulp.babel.js, https://github.com/gulpjs/gulp-cli/blob/master/test/fixtures/config/foo/bar/.gulp.js, https://github.com/gulpjs/gulp-cli/blob/master/test/fixtures/config/qux/.gulp.js) and they don't seem to be referenced anywhere. Do they need to be removed as well?

@phated
Copy link
Member

phated commented Jun 6, 2025

I think we need to remove both the readme and unused test files. I forgot to remove both with my translation work.

@folliehiyuki
Copy link
Author

I deleted all the relevant files and npm run test still passed on my local machine.

@folliehiyuki folliehiyuki changed the title fix: update DESCRIPTION message according to the description option Remove references to description configuration property Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants