Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm test aborts due to lint style errors #38

Closed
BurtHarris opened this issue Jun 6, 2017 · 2 comments · Fixed by #40
Closed

npm test aborts due to lint style errors #38

BurtHarris opened this issue Jun 6, 2017 · 2 comments · Fixed by #40

Comments

@BurtHarris
Copy link
Contributor

Now you've done it, got me interested enough to clone, build, and test. 👍

Running the command npm test gives me 7 minor issues, and exits with failure. They are all basically like this:

Invalid line break at test/streams.js :
     1 |'use strict';
---------------------^
     2 |
     3 |var expect = require('expect');


7 code style errors found.

I don't know your lint style, is it objecting to the semicolon, or something about the line break?

I'm on a Windows 10 machine if it matters, running node v6.10.3 and npm v5.0.3.

@BurtHarris
Copy link
Contributor Author

BurtHarris commented Jun 6, 2017

Just checked, it's the CRLF style line endings that seem to be the issue. git's default behavior seems to convert line endings to the local convention when I cloned the project, but it stores them back in the repository in neutral form.

I would suggest that based on this, having lint enforce this rule is heavy-handed unless something goes into the project telling git to not convert line endings.

@phated
Copy link
Member

phated commented Jun 6, 2017

I'm open to a .gitattributes file that forces text eol=lf - feel free to submit.

BurtHarris pushed a commit to BurtHarris/async-done that referenced this issue Jun 7, 2017
@phated phated closed this as completed in #40 Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants