removed setOpenPMDUnit, and it will be handled by applications

set default axis labels to be "x/y/z" for 1/2/3-Dims other behaviours should be done in application codes removed print statements
guj · Feb 14, 2024 · 4281967 · 4281967
1 parent 963dcac
commit 4281967
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 36 deletions.
diff --git a/Src/Extern/openPMD-api/AMReX_PlotFileOPENPMD.cpp b/Src/Extern/openPMD-api/AMReX_PlotFileOPENPMD.cpp
@@ -594,8 +594,6 @@ namespace amrex::openpmd_api {
       mesh.setAttribute("fieldSmoothing", "none");
       mesh_comp.resetDataset(dataset);
 
-      helper::setOpenPMDUnit( mesh, varName.m_FieldName );
-
       auto relative_cell_pos = helper::getRelativeCellPosition(mf);     // AMReX Fortran index order
       std::reverse( relative_cell_pos.begin(), relative_cell_pos.end() ); // now in C order
       mesh_comp.setPosition( relative_cell_pos );

diff --git a/Src/Extern/openPMD-api/AMReX_PlotFileUtilOPENPMD.H b/Src/Extern/openPMD-api/AMReX_PlotFileUtilOPENPMD.H
@@ -23,36 +23,6 @@ namespace amrex::openpmd_api
 {
     namespace helper
     {
-      inline void
-      setOpenPMDUnit ( openPMD::Mesh mesh, std::string const& field_name )
-      {
-        if (field_name[0] == 'E'){
-          mesh.setUnitDimension({
-              {openPMD::UnitDimension::L,  1},
-              {openPMD::UnitDimension::M,  1},
-              {openPMD::UnitDimension::T, -3},
-              {openPMD::UnitDimension::I, -1},
-            });
-        } else if (field_name[0] == 'B'){
-          mesh.setUnitDimension({
-              {openPMD::UnitDimension::M,  1},
-              {openPMD::UnitDimension::I, -1},
-              {openPMD::UnitDimension::T, -2}
-              });
-        }else if (field_name[0] == 'j'){ // current
-          mesh.setUnitDimension({
-              {openPMD::UnitDimension::L, -2},
-              {openPMD::UnitDimension::I,  1},
-            });
-        } else if (field_name.substr(0,3) == "rho"){ // charge density
-          mesh.setUnitDimension({
-              {openPMD::UnitDimension::L, -3},
-              {openPMD::UnitDimension::I,  1},
-              {openPMD::UnitDimension::T,  1},
-            });
-        }
-      } // name space helper
-
       // from warpx Utils/RelativeCellPosition.cpp
       inline std::vector< double >
       getRelativeCellPosition(amrex::MultiFab const& mf)

diff --git a/Src/Extern/openPMD-api/AMReX_PlotFileUtilOPENPMD_PTLImpl.H b/Src/Extern/openPMD-api/AMReX_PlotFileUtilOPENPMD_PTLImpl.H
@@ -26,9 +26,6 @@ namespace amrex::openpmd_api
     {
       BL_PROFILE("amrex::openpmd_api::WriteParticles()");
 
-      amrex::Print()<<"   Real: "<<pc.NStructReal<<" "<<pc.NumRealComps()<<"\n";
-      amrex::Print()<<"   Int:  "<<pc.NStructInt<<" "<<pc.NumIntComps()<<"\n";
-
       if ((m_OpenPMDHandler == nullptr) || (m_OpenPMDHandler->m_Writer == nullptr)) {
         return;
       }

diff --git a/Tests/openPMDTests/ptls/warpxWriter.H b/Tests/openPMDTests/ptls/warpxWriter.H
@@ -94,7 +94,7 @@ void AMReX_warpxWriter::SetupMeshComp (openPMD::Mesh& mesh,
   mesh.setAttribute("fieldSmoothing", "none");
   mesh_comp.resetDataset(dataset);
 
-  amrex::openpmd_api::helper::setOpenPMDUnit( mesh, varName.m_FieldName );
+  //amrex::openpmd_api::helper::setOpenPMDUnit( mesh, varName.m_FieldName ); // removed this function. define in app if needed
 
   auto relative_cell_pos = amrex::openpmd_api::helper::getRelativeCellPosition(mf);     // AMReX Fortran index order
   std::reverse( relative_cell_pos.begin(), relative_cell_pos.end() ); // now in C order