Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more polishing #72

Merged
merged 54 commits into from
Sep 5, 2024
Merged

more polishing #72

merged 54 commits into from
Sep 5, 2024

Conversation

guillp
Copy link
Owner

@guillp guillp commented Sep 5, 2024

  • renamed MismatchingAcr to MismatchingIdTokenAcr
  • added IdToken.authorized_party property
  • changed IdToken.auth_time to IdToken.auth_datetime
  • improved IdToken validation in BearerToken.validate_id_token()

- convert `TokenEndpointPoolingJob` to an `attrs` class
- mock `time.sleep` in tests
- move `coverage` config to `pyproject.toml`
- deps update
- convert `TokenEndpointPoolingJob` to an `attrs` class
- mock `time.sleep` in tests
- move `coverage` config to `pyproject.toml`
- deps update
- renamed `MismatchingAudience` to `MismatchingIdTokenAudience`
- renamed `MismatchingAzp` to `MismatchingIdTokenAzp`
- renamed `MismatchingNonce` to `MismatchingIdTokenNonce`
- introduced `MismatchingIdTokenIssuer`
- introduced many custom exceptions
- updated docstrings with `Raises:` sections
# Conflicts:
#	poetry.lock
#	requests_oauth2client/__init__.py
#	requests_oauth2client/tokens.py
#	tests/unit_tests/test_oidc.py
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (47995d7) to head (7bcdfe6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1667      1683   +16     
=========================================
+ Hits          1667      1683   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guillp guillp changed the title Chore/ruff more polishing Sep 5, 2024
@guillp guillp merged commit 4962599 into main Sep 5, 2024
8 checks passed
@guillp guillp deleted the chore/ruff branch September 5, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants