Fixes gcc11 c++20 compilation error

[actboy168]

3rd/ozz-animation/include/ozz/base/containers/std_allocator.h:52:28: error: expected unqualified-id before 'const'
   52 |   StdAllocator<value_type>(const StdAllocator<_Other>&) noexcept {}
      |                            ^~~~~
3rd/ozz-animation/include/ozz/base/containers/std_allocator.h:52:28: error: expected ')' before 'const'
   52 |   StdAllocator<value_type>(const StdAllocator<_Other>&) noexcept {}
      |                           ~^~~~~
      |                            )

[guillaumeblanc]

Hi,

thanks for reporting the issue and submitting a PR ! The fix looks good.

I tried to reproduce the error, writing a unit test that was missing: https://github.com/guillaumeblanc/ozz-animation/blob/feature/allocator/test/base/containers/std_containers_tests.cc#L43. I was expecting to use it to test your fix, but I couldn't trigger the error. Any idea?

Cheers,
Guillaume

[actboy168]

I checked my compiler options, this error is only raised under c++20.

[guillaumeblanc]

Thanks for checking!
I was able to reproduce the issue with c++20: https://github.com/guillaumeblanc/ozz-animation/actions/runs/1636673502, so I'll merge the PR to this new branch.

Cheers,
Guillaume

[guillaumeblanc]

Seems something is still bothering g++11: https://github.com/guillaumeblanc/ozz-animation/actions/runs/1636950038
Any idea?

[actboy168]

I can't reproduce it. It may be caused by out of memory.

https://stackoverflow.com/questions/30887143/make-j-8-g-internal-compiler-error-killed-program-cc1plus

[guillaumeblanc]

I think you're right, build passes if I disable parallel build: https://github.com/guillaumeblanc/ozz-animation/actions/runs/1643126498.
Thanks for your help.