Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guild page): Vercel ISR issues #1391

Merged
merged 8 commits into from
Jul 16, 2024
Merged

fix(guild page): Vercel ISR issues #1391

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1c1bf9f
fix(NavMenu): temporarily remove ThemeToggle
BrickheadJohnny Jul 16, 2024
c4ca416
fix(AppErrorBoundary): don't import the error page
BrickheadJohnny Jul 16, 2024
152bd3f
Revert "fix(AppErrorBoundary): don't import the error page"
BrickheadJohnny Jul 16, 2024
33ee73d
Revert "fix(NavMenu): temporarily remove ThemeToggle"
BrickheadJohnny Jul 16, 2024
5bcaedd
feat: try the `bundlePagesExternals` config option
BrickheadJohnny Jul 16, 2024
311f2c9
chore: package-lock update
BrickheadJohnny Jul 16, 2024
45d5472
remove `bundlePagesExternals` from next config
BrickheadJohnny Jul 16, 2024
f04047c
fix(next.config.js): set `bundlePagesExternals` to `true`
BrickheadJohnny Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "fix(AppErrorBoundary): don't import the error page" 
This reverts commit c4ca416.
  • Loading branch information
@BrickheadJohnny
BrickheadJohnny committed Jul 16, 2024
commit 152bd3f350a91bba37640d61f61f9e73ca5cc0af
5 changes: 2 additions & 3 deletions src/v2/components/AppErrorBoundary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Bugsnag from "@bugsnag/js"
// import ErrorPage from "pages/_error"
import ErrorPage from "pages/_error"
import { PropsWithChildren } from "react"
import { ErrorBoundary } from "react-error-boundary"

Expand All @@ -18,8 +18,7 @@ const AppErrorBoundary = ({ children }: PropsWithChildren<unknown>) => (
}
})
}}
// fallback={<ErrorPage />}
fallback={null}
fallback={<ErrorPage />}
>
{children}
</ErrorBoundary>
Expand Down